search

alexmohr / media_player.sony

Custom component for Home Assistant to control Sony devices
Apache License 2.0
15 stars 8 forks source link

Add volume level #36

Closed Liborsaf closed 2 months ago

Liborsaf commented 3 months ago

Shouldn't this be also debug/info? https://github.com/alexmohr/media_player.sony/blob/c834574c6ee2ead77ecfd175d47fbbc68b756114/custom_components/sony/media_player.py#L191 https://github.com/alexmohr/media_player.sony/blob/c834574c6ee2ead77ecfd175d47fbbc68b756114/custom_components/sony/media_player.py#L192

alexmohr commented 3 months ago

Shouldn't this be also debug/info?

https://github.com/alexmohr/media_player.sony/blob/c834574c6ee2ead77ecfd175d47fbbc68b756114/custom_components/sony/media_player.py#L191

https://github.com/alexmohr/media_player.sony/blob/c834574c6ee2ead77ecfd175d47fbbc68b756114/custom_components/sony/media_player.py#L192

Yes, would make sense to change this as well. Thanks

Liborsaf commented 2 months ago

Is this okay to merge or does it need some tweaks?

Edit: Sorry, missed those linting issues :D Will fix now

Liborsaf commented 2 months ago

Will implement set volume into this MR as well

Liborsaf commented 2 months ago

I will always be forgetting about those linting things :D

Liborsaf commented 2 months ago

@alexmohr Wouldn't be better if linting doesn't require approval to run?

alexmohr commented 2 months ago

@alexmohr Wouldn't be better if linting doesn't require approval to run?

Changed repo settings to Require approval for first-time contributors who are new to GitHub which is the most liberal setting GitHub allows :)

Liborsaf commented 2 months ago

@alexmohr Wouldn't be better if linting doesn't require approval to run?

Changed repo settings to Require approval for first-time contributors who are new to GitHub which is the most liberal setting GitHub allows :)

I see :) This MR should be ready for merge, could you please review it?