search

alexmohr / sonyapilib

Contains a python api to control sony devices.
MIT License
20 stars 11 forks source link

Linting, style, pep8 etc #17

Closed dilruacs closed 5 years ago

dilruacs commented 5 years ago

This might be very pedantic ;-) I created a "lint" branch in my fork and fixed a series of pylint errors.

The errors remaining are lines that are too long at some places and missing docstrings

dilruacs commented 5 years ago

https://github.com/alexmohr/sonyapilib/pull/18

alexmohr commented 5 years ago

Most of these are already fixed in v4. I'm going to merge it anyway but I have to take a look at merging it into this branch first

alexmohr commented 5 years ago

I'm not a fan of adding a docstring to self explanatory methods. Maybe a linter configuration should be added.

dilruacs commented 5 years ago

It is your library, you make the rules :-) I ignored the missing docstring errors

alexmohr commented 5 years ago

Great work it matched the things I've changed already in v4 perfectly. Fixed in #18