Code style: "Redefining built-in 'id'"

alexmohr / sonyapilib

Contains a python api to control sony devices.

MIT License

20 stars 11 forks source link

Code style: "Redefining built-in 'id'" #20

Closed dilruacs closed 5 years ago

dilruacs commented 5 years ago

id() is a built-in function of Python. Using id as a variable-name throws warnings.

See:

https://github.com/alexmohr/sonyapilib/blob/367490d53dbd8b4c20ea145f14600e3e3356ef71/sonyapilib/device.py#L268

Fix: https://github.com/alexmohr/sonyapilib/pull/21

alexmohr commented 5 years ago

I appreciate your review but this is aswell already fixed in v4. I am currently refactoring large parts of the code, adding some tests and linting aswell as travis.

dilruacs commented 5 years ago

OK, in that case, I will stop reviewing code style, linting etc. until you push your v4 branch. So far, I only noticed the unit tests.