search

alexmohr / sonyapilib

Contains a python api to control sony devices.
MIT License
20 stars 11 forks source link

Add support for volume control for Home Cinéma like BVD-E2100 #40

Closed ptimatth closed 4 years ago

ptimatth commented 4 years ago

Just add support, for volume control. I have updated media_player too

alexmohr commented 4 years ago

Please let me know if you need help writing a testcase. It should be enough to add the methods you've added to the list in the following file / line. https://github.com/alexmohr/sonyapilib/blob/6194f9d258eb86231e7187f9193c68573144654e/tests/device_test.py#L547

ptimatth commented 4 years ago

CI still finish with error code 16, i will check that now

ptimatth commented 4 years ago

\o/ have done, sorry, my first development with CI on python ;)

alexmohr commented 4 years ago

You can run the tests on your local machine by running py.test tests/*_test.py it is a bit easier than pushing and waiting for travis.

ptimatth commented 4 years ago

Yes, i found it just before last ;)

ptimatth commented 4 years ago

just a precision, it only work with static button volume, not with a scroll bar

ptimatth commented 4 years ago

I will maybe add this later...