alexmojaki / eval_type_backport

Like `typing._eval_type`, but lets older Python versions use newer typing features.
MIT License
11 stars 2 forks source link

Use a simpler "mark as used" technique in tests #22

Closed bswck closed 7 months ago

alexmojaki commented 7 months ago

It's a nice idea but it doesn't do the trick in PyCharm, and I'm not sure it's an improvement anyway.

bswck commented 7 months ago

It's a nice idea but it doesn't do the trick in PyCharm, and I'm not sure it's an improvement anyway.

For PyCharm, we could simply use # noqa: F401.

bswck commented 7 months ago

I'm not sure it's an improvement anyway.

I'd argue that anything else than https://github.com/alexmojaki/eval_type_backport/blob/1663fb5d1c1feb7eac9ac7cb2fba865422bb455b/tests/test_eval_type_backport.py#L12 is better. 😛