search

alexmojaki / pyodide-worker-runner

MIT License
23 stars 2 forks source link

Use correct entry list #12

Closed winniederidder closed 2 years ago

winniederidder commented 2 years ago

The wrong list was being used when actually installing imports using micropip. Should be merged and released ASAP as using the new version does not work right now. Not sure how we both missed this :P properly naming variables truly is one of the hardest things in programming.

alexmojaki commented 2 years ago

lol this is why we need tests.

I think it'd be better to just replace the to_install variable with the new list since the old one isn't used again, then there's no chance of confusion.

winniederidder commented 2 years ago

I think it'd be better to just replace the to_install variable with the new list since the old one isn't used again, then there's no chance of confusion.

Did some further cleanups so that everything should be clear and concise.