search

alexmojaki / s3-stream-upload

Manages streaming of data to AWS S3 without knowing the size beforehand and without keeping it all in memory or writing to disk.
MIT License
208 stars 62 forks source link

Sdk v2 - test rewrite #42

Closed alexwhiteoval closed 2 years ago

alexwhiteoval commented 2 years ago

Would be good to get the v2 SDK into master soon to resolve some of the high vulnerabilities.

alexmojaki commented 2 years ago

Ooooh, exciting!

However it's hard for me to review this since master has changed so much since my upgrade branch. Combining master and that branch needs to be separated from the additional work you've done.

I see three options:

  1. Make a PR that only merges master into my branch.
  2. Make a PR that would merge into master directly, so I'll review the upgrade (including my code) and testing all in one go without the noise of old commits into master.
  3. I merge master into my branch and this PR gets refreshed, and hopefully I resolve merge conflicts in mostly the same way that you do.

What would you prefer?

alexwhiteoval commented 2 years ago

Hi,

I'll go with option 2. I can make a new PR for a merge straight to master, which is probably easiest for everyone, as you will be able to review the changes for easily.