search

alexmorley / CodeOfConduct.Builder

(WIP!) An easy way to build the perfect Code of Conduct for your event/community/organisation
http://codeofconduct.io
Creative Commons Attribution 4.0 International
13 stars 13 forks source link

Empty strings in JSONs show as empty bullets in Code of Conduct. #23

Closed gerardogalvez closed 7 years ago

gerardogalvez commented 7 years ago

ContributorCovenant.json and confcodeofconduct.json have empty strings at the end of their respective howto arrays, displaying them in the Code of Conduct as empty bullets as shown in the screenshots. Either remove those empty strings or check for empty strings when adding those elements.

screen shot 2017-10-02 at 3 04 45 pm
gerardogalvez commented 7 years ago

I can submit a PR for this and #24 in case it's something it should be done.

alexmorley commented 7 years ago

@gerardogalvez yes please. You can be pretty heavy-handed with the javascript as its very rough atm. I think maybe it would be good to have a default saying "this code of conduct doesn't include info about X; maybe add something yourself?". What do you think?

gerardogalvez commented 7 years ago

That sounds great! I also thought about not including the section at all but that having it there gives a clue about what the Code could have.