search

alexmurray / emacs-snap

GNU Emacs in a snap
https://snapcraft.io/emacs
71 stars 13 forks source link

Any plans to add `pgtk` branch to the mix? #23

Closed rassie closed 2 years ago

rassie commented 3 years ago

Apparently, there are two hot 28.x branches right now: gccemacs and pgtk. Both seem to be game-changers in their own domain, to the point that both are included in many emacs 28.x binary compilation.

Since gccemacs is already included in the edge branch of this snap and it is expected that both on these branches will get merged in the 28.x release cycle, are there any plans to include the pgtk branch in the snap?

rassie commented 3 years ago

Maybe you could just make use of https://github.com/flatwhatson/emacs, which is used to make regular builds already.

alexmurray commented 3 years ago

Thanks for raising this issue - pgtk is something I have been meaning to check out for a while. I am a bit concerned however about rolling this into the edge channel as well as nativecomp since I am a bit worried about conflicts between the two branches. Currently they don't merge without conflict and I would prefer to have a solution I can automate via the snapcraft.yaml to build from the official upstream mirror rather than someone else's fork. So until they can be merged without conflict this will have to remain a wishlist item.

rassie commented 3 years ago

native-comp has been merged to master, but the pgtk branch sadly looks somewhat stale :( Would you pick it if it got rebased on master?

alexmurray commented 3 years ago

I'd be happy to take a look and see if we can include it if it merges cleanly.

rassie commented 2 years ago

I think this is largely obsolete now. It seems the pgtk branch is due to be merged into master soon-ish, so it will should be available from the edge channel in the future. Good enough to close?

alexmurray commented 2 years ago

Fine by me - thanks @rassie