search

alexmurray / flycheck-clang-analyzer

Integrate Clang Static Analyzer with flycheck for on-the-fly static analysis in Emacs
35 stars 5 forks source link

Classify RTags as inactive if it can't provide compilation flags #13

Closed itollefsen closed 5 years ago

itollefsen commented 6 years ago

When working on a project, it's quite common to also open source files outside of the current project. Trying to analyze those files will inevitably fail because RTags can't provide compilation flags for them.

This modifies `flycheck-clang-analyzer--rtags-active' to consider RTags to be inactive if it can't provide compilation flags for the current buffer, even if it's enabled and running.

alexmurray commented 6 years ago

Thanks for this - please see the review comment

itollefsen commented 5 years ago

I would prefer if instead of just (rtags-compilation-flags) was (> (length (rtags-compilation-flags)) 0) then the (if (...) t nil) could be removed and it could be just the (and ...) as original

Yes, of course. Now fixed.