search

alexmurray / flycheck-posframe

Show flycheck errors via posframe.el
60 stars 9 forks source link

Add posframe width support #14

Closed abbaswasim closed 5 years ago

abbaswasim commented 5 years ago

This is required so people can set width of the popup messages. If the width of string displayed is 10 characters bigger than the default width of 80, the string width is used instead.

alexmurray commented 5 years ago

Can you describe why someone would want to force the width to be larger than the string width? Currently posframe will already use the string width so I do not see a need for this.

abbaswasim commented 5 years ago

Thats probably an oversight from my side. But I have tried different themes and it doesn't let me see the extra bits for smaller strings. My understanding was that posframe fixes that so I didn't handle it. This PR is only for wrapping longer strings. Attached are two different themes on my setup.

GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F2511)) of 2018-05-31

Screenshot 2019-05-21 at 09 17 06 Screenshot 2019-05-21 at 09 17 24

abbaswasim commented 5 years ago

One thing I would like to still fix is, having a full block instead of just the block of text highlighted. It looks less pretty if you have one and half lines. I was thinking of adding spaces at the end (80 - (% 80)) but didn't get to that yet.

wasimabbas-arm commented 5 years ago

Sorry not happy with this. Seems to be buggy. You can reject it.

alexmurray commented 5 years ago

Ok