search

alexmurray / flycheck-posframe

Show flycheck errors via posframe.el
60 stars 9 forks source link

Posframe doesn't hide automatically on moving the point out of the error line #27

Open Gleek opened 3 years ago

Gleek commented 3 years ago

This might be an issue in recent updates of posframe but flycheck-posframe has stopped hiding automatically once moved out of the error line. It stays open until I hover on it with my mouse or change my focus to the minibuffer.

I have solved it by running the flycheck posframe hide on post-command-hook.

(add-hook 'post-command-hook #'flycheck-posframe-hide-posframe)
zhenwenc commented 3 years ago

@Gleek Do you notice quite sticky when moving the cursor up/down after having this hook?

alexmurray commented 3 years ago

Apologies for taking so long to get to this issue, I expect to have a fix ready later this morning.

alexmurray commented 3 years ago

This should be fixed now - a new package should be available on MELPA with this fix within ~24 hours.

mattsawyer77 commented 3 years ago

hi @alexmurray, it seems the original issue returned with the recent commit 911368472919b33db622c2d1ad062dadb7b20ca3. It seemed to work properly for me with the previous commit 6eea204138721f511051af5138326fecaad237b7.

If it helps, I'm using doom-emacs with lsp and lsp-ui.

alexmurray commented 3 years ago

Damn, ok I have a new implementation in 8f60c9b - let me know if that works any better - or if anyone notices any other weirdness...

mattsawyer77 commented 3 years ago

thanks @alexmurray ! 8f60c9b seems to work perfectly for me.