search

alexmurray / flycheck-posframe

Show flycheck errors via posframe.el
60 stars 9 forks source link

posframe always opens over the minibuffer #7

Closed CSRaghunandan closed 6 years ago

CSRaghunandan commented 6 years ago

Looks like the latest commit broke something? I'm getting the posframe popup over the minibuffer instead of below the cursor position

alexmurray commented 6 years ago

What emacs version are you running? I have noticed posframe is broken completely for me in current emacs-snapshot for the Ubuntu elisp PPA - also I haven't made any changes to flycheck-posframe that would affect positioning - so either this is a bug in Emacs itself or a bug in posframe.

CSRaghunandan commented 6 years ago

I am running emacs 26.091 devel release and I updated the packages flycheck-posframe broke. I also tried updating to emacs 27.0.50 and even it has same issue.

I'm on MacOS Sierra.

alexmurray commented 6 years ago

Can you definitely confirm that it is broken if using the earlier version of flycheck-posframe but with the latest version of other packages? Since I can't reproduce I can't do a lot without more details...

CSRaghunandan commented 6 years ago

Sure, i'll with earlier version of flycheck-posframe and report the same after my day job is done.

Thanks

Update: I copied over the older flycheck-posframe version and byte recompiled the file and restarted emacs and enabled flycheck-posframe-mode in a buffer and it's working fine! Only the first invocation is off, but after that it works as intended. Now I'm running emacs 27:

Emacs version: GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G1212))
 of 2018-03-14, built using commit d993d00394707e69b6ac7befeb72140d9b12a4e9.

./configure options:
  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD-d993d00/share/info/emacs --prefix=/usr/local/Cellar/emacs/HEAD-d993d00 --without-x --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-rsvg --with-ns --disable-ns-self-contained

Features:
  RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS

Update2: reinstalled the latest flycheck-posframe and ran into the same issue. Could this a mac specific issue?

Bump @alexmurray !

alexmurray commented 6 years ago

Sorry for the delay in looking at this - I am not using MacOS and don't have easy access to it so it is hard for me to investigate - just for some more details - can you please confirm the last working version of flycheck-posframe? Also I just made a change to not always delete the posframe but to just hide it (specifically for an issue another user was having on MacOS - see issue #8) - so perhaps this will help you as well? Can you please try the current git version (or wait a day or so for MELPA to update to the latest) and let me know if that is any better?

CSRaghunandan commented 6 years ago

Okay just updated the package on MELPA and now the popup frame is opening in the right location! Thanks for the fix

First invocation is still over the minibuffer, but after that, it's working as expected. Also, I could never get posframe to work in fullscreen in mac. Each popup frame opens up in own fullscreen window for mac. But, I don't really use emacs in fullscreen mode.

alexmurray commented 6 years ago

I suggest for the remaining issues (wrongn initial placement and fullscreen woes) to open an issue in the posframe project itself - https://github.com/tumashu/posframe