alexmurray / flycheck-posframe

Show flycheck errors via posframe.el
60 stars 9 forks source link

Reuse frame instead of deleting and recreating #8

Closed aaronjensen closed 6 years ago

aaronjensen commented 6 years ago

Hi, thanks again for flycheck-posframe. I'm wondering if it can be reworked slightly to reuse the posframe similar to how company-childframe does it. Every time a frame is created on macOS it causes a flicker in the top left of the parent frame. It's also slow, and worst of all, destroying the frame makes it far more likely to run into bug#30800 which just outright crashes emacs when it happens.

alexmurray commented 6 years ago

Thanks - changed the behaviour to just hide the frame instead of deleting it in https://github.com/alexmurray/flycheck-posframe/commit/61bdfd4b04e1651163fdcaa7dc631ad073b3e513 - let me know if this works better for you.

aaronjensen commented 6 years ago

Awesome, thanks for the quick fix.