alexmurray / remmina-search-provider

GNU General Public License v3.0
12 stars 9 forks source link

Icon missing with remmina 1.2.31 #22

Closed negesti closed 6 years ago

negesti commented 6 years ago

After upgrading remmina today (fedora 28, remmina 1.2.31.3-1) entries in the overview no longer have an icon and are rendered with a width of ~ 4px.

Changing the icon name in extension.js seems to fix this:

 82         if (remminaApp) {
 83             icon = remminaApp.create_icon_texture(size);
 84         } else {
 85             icon = new St.Icon({ gicon: new Gio.ThemedIcon({
 86               name: 'org.remmina.Remmina'
 87             }), icon_size: size });
 88         }

Name was "remmina".

I'm not sure if this works with remmina < 1.2.31

alexmurray commented 6 years ago

Thanks for reporting this - can you try the latest version from git and see if this resolves the issue for you?

negesti commented 6 years ago

works like a charm

alexmurray commented 6 years ago

Great - I will close this issue then and push a new version to extensions.gnome.org soon.

alexmurray commented 6 years ago

Have uploaded version 8 containing this fix to extensions.gnome.org so we just have to wait for that to be approved (https://extensions.gnome.org/review/8361)

alexmurray commented 6 years ago

Looks like this has been approved and is available for official download on extensions.gnome.org