search

alexmurray / remmina-search-provider

GNU General Public License v3.0
12 stars 9 forks source link

Search results don't match search string #6

Closed rumbin closed 9 years ago

rumbin commented 9 years ago

Note: This issue was already posted in the comments section of commit c8e4bb6.

Description

While the search provider itself is working, the search results are wrong for some reason: When entering the name of any of the (many) configured connections, the displayed result(s) don't show any similarity with the search term. Consequently, the intended connection is not found. The shown wrong results seem to be (mostly) reproducible for different search terms, though.

Example

Below are some connection config files from ~\.remmina\*.remmina:

File 1414583282863.remmina:

[remmina] keymap= ssh_auth=0 quality=9 disableencryption=0 ssh_charset= ssh_privatekey= server=localhost hscale=0 group=VNC password= name=localhost ssh_loopback=0 viewonly=0 ssh_username= ssh_server= window_maximize=1 aspectscale=0 protocol=VNC window_height=1104 window_width=1280 vscale=0 ssh_enabled=0 username= showcursor=0 disableserverinput=0 colordepth=24 disableclipboard=0 viewmode=1

File 1414583306725.remmina:

[remmina] keymap= ssh_auth=0 quality=9 disableencryption=0 ssh_charset= ssh_privatekey= server=int-pligc hscale=0 group=VNC password= name=Int-PLIGC ssh_loopback=0 viewonly=0 ssh_username= ssh_server= window_maximize=1 aspectscale=0 protocol=VNC window_height=1104 window_width=1280 vscale=0 ssh_enabled=0 username= showcursor=0 disableserverinput=0 colordepth=24 disableclipboard=0 viewmode=1

File 1414583413195.remmina:

[remmina] keymap= ssh_auth=0 quality=9 disableencryption=0 ssh_charset= ssh_privatekey= viewmode=1 colordepth=24 hscale=0 group=VNC password= name=Int-PLD ssh_loopback=0 viewonly=0 ssh_username= ssh_server= window_maximize=1 window_width=1280 protocol=VNC window_height=1104 vscale=0 ssh_enabled=0 username= showcursor=0 disableserverinput=0 server=int-pld aspectscale=0 disableclipboard=0

File 1414584196184.remmina:

[remmina] keymap= ssh_auth=0 quality=9 disableencryption=0 ssh_charset= ssh_privatekey= viewmode=1 colordepth=24 hscale=0 group=VNC password= name=intcsputter ssh_loopback=0 viewonly=0 ssh_username= ssh_server= window_maximize=1 window_width=1280 protocol=VNC window_height=1104 vscale=0 ssh_enabled=0 username= showcursor=0 disableserverinput=0 server=intcsputter aspectscale=0 disableclipboard=0

File remmina.pref:

[remmina_pref] save_view_mode=true save_when_connect=true invisible_toolbar=false always_show_tab=true hide_connection_toolbar=false default_action=0 scale_quality=3 hide_toolbar=false hide_statusbar=false show_quick_search=false small_toolbutton=true view_file_mode=0 resolutions=1920x1200,1680x1050,1280x1024,1280x960,1152x864,1024x768 main_width=600 main_height=400 main_maximize=false main_sort_column_id=1 main_sort_order=0 expanded_group= toolbar_pin_down=false sshtunnel_port=4732 applet_new_ontop=false applet_hide_count=false applet_enable_avahi=false disable_tray_icon=false minimize_to_tray=false recent_maximum=10 default_mode=0 tab_mode=0 auto_scroll_step=10 hostkey=65508 shortcutkey_fullscreen=65481 shortcutkey_autofit=49 shortcutkey_nexttab=65363 shortcutkey_prevtab=65361 shortcutkey_scale=115 shortcutkey_grab=107 shortcutkey_minimize=65478 shortcutkey_disconnect=65473 shortcutkey_toolbar=116 vte_font= vte_allow_bold_text=false vte_lines=512

With those example config files, the following pairs of search terms and results are obtained. The string part in "[…]" does not lead to any further discrimination of the search results:

l[ocalhost] → Int-PLD i[nt…] → intcsputter (only one result after entering "i", although there should be three matches) i[gc] → intcsputter (of course the same result like above) s[put…] → localhost s[put…] → intcsputter (showing bad reproducibility…) p[ld] → intcsputter l[d] → localhost l[igc] → localhost ligcc → (no match, so the system is aware that "ligc" is there — from PLIGC —, but no "ligcc") g[c] → Int-PLIGC c → intcsputter h → localhost t → intcsputter a → intcsputter a[+any other letter or number] → no match d → Int-PLD b → (no match)

So in view of this example setup, it seems that:

alexmurray commented 9 years ago

I am unable to reproduce this locally - what language / locale are you using?

I have been able to reproduce the particular issue of:

And this should be fixed in https://github.com/alexmurray/remmina-search-provider/commit/dbbbbbab37bf31a22f80b844aa9e6f6e5e7896e6

rumbin commented 9 years ago

Interestingly, things are getting worse now: The extension seems to fail upon loading already. At least the extensions.gnome.org page shows "Error" for the Remmina Search Provider plugin. I tried do find some error messages, but looking-glass (Atlt+F2 → lg) says that the plugin "has not emitted any errors". Should I file a new issue for this?

Regarding your question: The system locale is set to en_US.UTF-8. Gnome's language is set to English (US), Formats are German. Input sources are set to German (no dead keys) and English (US).

If helpful, I can also try disabling other plugins for testing, as soon as the plugin is working again…

alexmurray commented 9 years ago

What do you mean 'Formats are German'?

If you run gnome-shell from a terminal this should print out where the extension is crashing:

gnome-shell --replace &
rumbin commented 9 years ago

First the good news: it is working now. Something got tainted in the extensions directory, I guess. I tested the remmina search provider extension in a clean test-user environment and it worked as it should. Copying the respective folder of the extension to my home-dir solved the issue.

Now the gnome-shell --replace command yields a warning: remmina-search-provider@alexmurray.github.com/extension.js 230]: variable results redeclares argument . But that seems to be harmless in terms of functionality.

Regarding the "Formats are German" puzzle: That meant, that in gnome's "Region & Language" dialog the formats for numbers and dates are set to German. But that is probably meaningless for the current issue.

I guess, this issue can be closed now. Thanks for your quick replies and please keep up the good work also for future versions of gnome-shell…