search

alexmustin / woocustomemails

Repo for the WC Custom Emails Per Product plugin
https://wordpress.org/plugins/woo-custom-emails-per-product/
GNU General Public License v2.0
21 stars 5 forks source link

"Custom Emails" tab not showing for certain types of products #18

Closed cantonbecker closed 4 years ago

cantonbecker commented 4 years ago

The popular LearnDash plugin adds a new type of product to Woo products. In addition to being able to select from "Variable" or "Simple" etc, you can select "Course".

When "Course" is selected, the Custom Emails tab disappears.

Expected behavior: Custom Emails tab should persist even when choosing an off-brand product type.

Screenshot 2020-07-09 12 56 54 Screenshot 2020-07-09 12 56 44

Temporary fix, I think? I added the class show_if_course to $display_classes_default in woo-custom-emails-per-product.php

alexmustin commented 4 years ago

@cantonbecker - I created a page for users to add that "show_if_xxx" class.

Custom Emails > WCE Settings Screen Shot 2020-07-09 at 12 29 22 PM

alexmustin commented 4 years ago

Please consider that I cannot develop this plugin to work with every possible WooCommerce Custom Post Type that exists. Some of these special products are setup to send emails outside of the way default WooCommerce Product emails are sent, making the process even harder.

The purpose of this plugin is to work with DEFAULT WooCommerce product types... that's it.

If you need to modify this for your own needs, feel free to fork it and go for it!

cantonbecker commented 4 years ago

That’s perfect, thanks very much for this extra bit of customizability. That means I won’t have to edit your plugin every time I update it. :)

From your earlier response, I do appreciate that this is a “use at your own risk” type of thing, since there’s no way you can guarantee that every woocommerce product type extension is going to behave as expected when it comes to triggering emails.

And thanks again for this excellent plugin. It’s a desperately needed feature for many woocommerce scenarios. I’ll be a happy paying customer if and when you create a commercial version of this plugin.

On Jul 9, 2020, at 1:29 PM, Alex Mustin notifications@github.com wrote:

@cantonbecker https://github.com/cantonbecker - I created a page for users to add that "show_if_xxx" class.

Custom Emails > WCE Settings https://user-images.githubusercontent.com/1307497/87082403-d5f9b100-c1df-11ea-86db-573d140f7b7d.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexmustin/woocustomemails/issues/18#issuecomment-656309896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7VFY7OSYSV6UM5KN3LHMLR2YLC7ANCNFSM4OV4UV5Q.

alexmustin commented 4 years ago

Thanks for the kind words @cantonbecker !