A few minor fixes - Githubissues

alexmyczko / fnt

apt for fonts, the missing font manager for macOS/linux

Other

489 stars 20 forks source link

Closed andrewshadura closed 1 year ago

andrewshadura commented 1 year ago

Use -z instead of old-school empty string comparison: This hasn’t been needed since POSIX standardised the behaviour of test.
Use command -v instead of non-standard which: unlike which, command is a shell built-in
Pre-create ~/.fnt before each write: this avoids an error message if e.g. running preview before update.

Also: how about rewriting fnt in a more sensible programming language, e.g. Python or Rust? 🙂

alexmyczko commented 1 year ago

Hi @andrewshadura thank you for the patch. Once I get to test it also on macOS chances are high this will get applied.

I'm not familiar with Python nor Rust, but if you can implement the same with less LOC, why not? Go for it.