alexnita3 / GalaxyRP

GNU General Public License v2.0
5 stars 3 forks source link

Animevents from OJP rewritten by Bart #118

Closed bartrpe closed 1 year ago

bartrpe commented 1 year ago

This is the animevents system coming from OJP 1.2. It's 0% mine, it's the work of Open Jedi Project developers. Unfortunately I can't specify who exactly among the developers coded that, as their repository history doesn't exist before 2006 and the code was already in their first commit.

All I did was replicating the changes done in OJP 1.2 that made animevents.cfg work properly. As you can see, it's 70% moving it from BG (both games) to specifically CGame and then some other tweaks that made it play sounds properly. Well, I guess code speaks for itself. It's been a feature of a long alive mod done by excellent team of devs so I really didn't inspect that all too well, to be frank. Other changes are just me modifying the way files are read, because it's different in OpenJK than it was done in old JK3-MP-SDK code. (trap changed to trap-> mostly, though).

@RepJunkieJr asked for this stuff loooong ago, but it was only now that I got the time to setup the tools to do this easily.

I've tested it rigorously and it works perfectly fine, but did that on my local fork of OpenJK. Then I just moved commits between repositories (yeah, you can do that. i can show people how to do it if you want) to push it here. I was never building your mod before so MAYBE there is something that needs to be tweaked but I can't really know that. Works 10/10 on OpenJK though. Can provide binaries for proof that the system works just fine!

But anyway enough talk, let the code speak for itself 👍🏻

bartrpe commented 1 year ago

https://gist.github.com/bartrpe/f4091bb9b3451d45839e5630c256f1cf - example animevents.cfg file - put it inside models/players/yourcharacter/

alexnita3 commented 1 year ago

Very good, tested with the provided file works great.

Thanks very much for the contribution!