search

alexobviously / bishop

A chess logic package for Dart with flexible variant support
https://pub.dev/packages/bishop
Other
19 stars 8 forks source link

Solve bug #9 #10

Closed malaschitz closed 1 year ago

alexobviously commented 1 year ago

You're definitely right that this is a bug, but this solution causes us to fail on a known perft result (see tests), so I'll have to have a look at this

malaschitz commented 1 year ago

Solved in https://github.com/alexobviously/bishop/commit/481b9b4d25b12df397c937f439be6fa2b6e033dd

alexobviously commented 1 year ago

Hey, there are a lot of changes for a single PR here (thanks for all the time you've spent on this), so I'm probably going to review implement all of these as separate commits (and @ you as coauthor), especially since some of these are related to things that I haven't decided how to handle yet (e.g. the grand chess thing)

alexobviously commented 1 year ago

Okay, I think everything in this PR is implemented now, so I'm gonna close it.