alexobviously / squares

A flexible chessboard widget for Flutter
https://pub.dev/packages/squares
Other
37 stars 15 forks source link

notation on large boards #10

Closed malaschitz closed 1 year ago

malaschitz commented 2 years ago

The moveFromAlgebraic(String alg) function only works correctly on an 8x8 board because the length of the normal stroke notation is always assumed to be 4. However, it can be longer on a larger board (Grand Chess). For example, after move Rb1 (a1b1), Black can play Rb10 (a10b10). The error will show up in the complex example when Grand Chess is chosen and played with black pieces.

alexobviously commented 1 year ago

Thanks for spotting this, weird that I didn't earlier. Closing this without merging because I fixed it in a slightly different way in https://github.com/alexobviously/squares/commit/bcc5f262648cafaaf237c9d6d7f50492245f9d40 (cleaning up the parsing code a little bit in general