search

alexopus / ComfyUI-Image-Saver

Save images with Civitai-compatible generation metadata in ComfyUI
MIT License
49 stars 8 forks source link

Some Sampler choices doesnt show on Civitai. #10

Closed Puddz closed 9 months ago

Puddz commented 9 months ago

As title says. Some of the samplers seem to have a different name compared to what they called on civitai, and civitai doesn't seem to pick it up. Like Euler Ancestral sampler shows up as Euler A on prompt readers and stuff, but civitai doesnt seem pick up that its Euler A and just doesnt fill that part of the generation data on.

alexopus commented 9 months ago

I tried with "Euler a" and it works. However, I had to switch to "normal" scheduler, if I do "karras" it doesn't recognize it, because "Euler a Karras" is not a valid combo on civitai's side: https://github.com/civitai/civitai/blob/main/src/server/common/constants.ts#L124-L146

Civitai combines sampler and scheduler into a single setting, like a1111 does. And supports only a subset of possible combinations.

This node will check for a valid combo: https://github.com/alexopus/ComfyUI-Image-Saver/blob/main/nodes.py#L176-L211 I suspect that you used Euler a with Karras, in which case it would be a combo which civitai doesn't support.

I could just ignore the scheduler at this point and only fill the sampler, but I think that would be more confusing. Rather, civitai/a1111 should split this setting, or at least support all possible combinations.

Puddz commented 9 months ago

Ah yeah, That's what happened. I basically always use karras. Well that solves that mystery. Thanks for answering.