alexopus / ComfyUI-Image-Saver

Allows you to save images with their generation metadata in ComfyUI. Compatible with Civitai. Works with png, jpeg and webp.
MIT License
31 stars 6 forks source link

I'm getting an error with this node about the path. #15

Closed J-Cott closed 2 months ago

J-Cott commented 2 months ago

I have tried using a folder name under output and a full system path but it happens both times.

Error occurred when executing Image Saver:

expected str, bytes or os.PathLike object, not NoneType

File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Image-Saver\nodes.py", line 295, in save_files modelhash = get_sha256(ckpt_path)[:10] File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Image-Saver\utils.py", line 10, in get_sha256 file_no_ext = os.path.splitext(file_path)[0] File "ntpath.py", line 230, in splitext

alexopus commented 2 months ago

The error indicates that the actual problem is the missing modelname, not the output directory. I'll make that more robust so that empty values can work. Meanwhile you can put a proper value in there and it should work. You can see how in the screenies in the readme, if you are unsure how.

alexopus commented 2 months ago

Model name can be left empty now, which will not include a model hash/name in the metadata.

J-Cott commented 2 months ago

Oh , I see, I wasn't using the image saver input nodes. All working now thanks for your help. they are a great node I really missed having my generation data included on Civitai when using ComfyUI , but now I can have it automatically :)