alexopus / ComfyUI-Image-Saver

Allows you to save images with their generation metadata in ComfyUI. Compatible with Civitai. Works with png, jpeg and webp.
MIT License
31 stars 6 forks source link

fixed sampler selection #16

Closed derZ-dev closed 2 months ago

derZ-dev commented 2 months ago
coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The recent update primarily enhances the `ImageSaver` class in the `nodes.py` file. The modifications include the addition of a new sampler option and updates to the `get_civitai_sampler_name` method, which now supports a new scheduler and features refined conditional logic. These changes aim to increase the class's flexibility and functionality, improving its integration and performance within the broader codebase. ## Changes | File(s) | Change Summary | |---------|----------------| | `nodes.py` | Updated the `ImageSaver` class by adding a new sampler option and modifying the `get_civitai_sampler_name` method to support a new scheduler and improve conditional logic. |

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 310b6993b7f77ad06ae11c5362661fb397de5245 and a8ab64c6357a4690257d9727311971ea2b154afb.
Files selected for processing (1) * nodes.py (1 hunks)
Additional Context Used
Ruff (3)
nodes.py (3)
7-7: `PIL.ExifTags` imported but unused --- 33-33: Do not use bare `except` --- 233-233: f-string without any placeholders
Additional comments not posted (5)
nodes.py (5)
`198-200`: Ensure that the new sampler 'DPM++ 3M SDE' is correctly handled in the `get_civitai_sampler_name` method. --- `218-219`: The addition of handling for the "exponential" scheduler in `get_civitai_sampler_name` method aligns with the PR's objectives to support new scheduler options. --- `303-303`: The modification to handle "_gpu" suffix in sampler names by stripping it before lookup is a crucial fix for ensuring all samplers produce expected outputs. --- `315-317`: Consider adding error handling for the `os.makedirs` call in `save_files` method to manage potential exceptions when creating directories. --- `347-353`: Ensure that the `piexif.insert` function is wrapped in a try-except block to handle potential exceptions from incorrect EXIF data handling.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
alexopus commented 2 months ago

Hey, thanks for the PR. Could you fix it so we have only the actual changes? Thx

derZ-dev commented 2 months ago

Hey, thanks for the PR. Could you fix it so we have only the actual changes? Thx

Hey. You're very welcome. Sure, I'll fix that asap.

derZ-dev commented 2 months ago

gonna reset my fork and create a new PR as soon as I'm done. sry for the delay...