fixed sampler name generation

[derZ-dev]

• added DPM++ 3M sampler names
• added Exponential scheduler

[coderabbitai[bot]]

Walkthrough

## Walkthrough The recent updates focus on refining the handling of sampler names within the codebase. This includes adding new keys to a dictionary, improving the naming logic based on the scheduler type, and standardizing the naming convention in file-saving functions. These changes aim to enhance clarity and functionality, especially in managing sampler names across different configurations. ## Changes | File(s) | Changes | |----------------|-----------------------------------------------------------------------------------------------------------------------| | `nodes.py` | - Added keys `'dpmpp_3m': 'DPM++ 3M'` and `'dpmpp_3m_sde': 'DPM++ 3M SDE'` to a dictionary.
- Updated `get_civitai_sampler_name` to append " Exponential" for `scheduler` set to "exponential".
- Modified `save_files` function to remove `'_gpu'` from `sampler_name`. |

---

Recent Review Details

**Configuration used: CodeRabbit UI**

Commits

Files that changed from the base of the PR and between 2c159c64b107a15654749a5831088dcc848bc512 and e9ac0e92896a1d41a0f7a490d34575e0479b1a19.

Files selected for processing (1)

* nodes.py (3 hunks)

Additional Context Used

Ruff (2)

nodes.py (2)

33-33: Do not use bare `except` --- 231-231: f-string without any placeholders

Additional comments not posted (3)

nodes.py (3)

`199-199`: Addition of new sampler names to the dictionary. This change correctly expands the sampler name mapping to include 'dpmpp_3m_sde'. Ensure that all references to this new key are consistent across the codebase. --- `216-217`: Modification to append "Exponential" to the sampler name when the scheduler is set to "exponential". The logic to append "Exponential" based on the scheduler type is correctly implemented. Ensure that this naming convention is consistently used wherever the scheduler type is relevant. --- `306-306`: Updated `civitai_sampler_name` assignment to replace `'_gpu'` with an empty string in `sampler_name`. This change ensures cleaner sampler names by removing the '_gpu' suffix where applicable. Verify that this change does not affect any dependencies that might rely on the original `sampler_name` format.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[alexopus]

Code looks good, but is there really just 'dpmpp_3m' in Comfy? I only see 'dpmpp_3m_sde' in my up-to-date checkout. Neither does it exist here: https://github.com/civitai/civitai/blob/main/src/server/common/constants.ts#L121-L146

[derZ-dev]

Code looks good, but is there really just 'dpmpp_3m' in Comfy? I only see 'dpmpp_3m_sde' in my up-to-date checkout. Neither does it exist here: https://github.com/civitai/civitai/blob/main/src/server/common/constants.ts#L121-L146

No, you're right. Thanks for the hint. I just assumed there was one and therefore added the key-value-pair. Removed it and updated my main branch.

[alexopus]

Looks good, thanks!