search

alexopus / ComfyUI-Image-Saver

Save images with Civitai-compatible generation metadata in ComfyUI
MIT License
45 stars 8 forks source link

Is possible do not leak my workflow? #18

Closed lverangel closed 4 months ago

lverangel commented 5 months ago

I think if i checked save workflow as json then it will not leak my worklow.

alexopus commented 4 months ago

Can you explain what you mean with "leak"?

lverangel commented 4 months ago

I sumbit my image on civitai, and a guy right click and save the picture ,then drag it into comfyUI, it will import my workflow. there are so many personal training notice in it. but at last, i found if save format as jpeg with the node, the image(workflow) can not be import. there is another custom node do this well,(civitai can read the prompt,checkpoints,etc... and do not 'leak' ) but it nolonger update, so i think this one can do it also. but i save as jpeg now,so, i think it not a problem

Alexopus @.***> 于2024年5月11日周六 02:29写道：

Can you explain what you mean with "leak"?

— Reply to this email directly, view it on GitHub https://github.com/alexopus/ComfyUI-Image-Saver/issues/18#issuecomment-2105081935, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3N3TZ66XY3RXQEYTMWDDZBUGXBAVCNFSM6AAAAABGQO32M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGA4DCOJTGU . You are receiving this because you authored the thread.Message ID: @.***>

alexopus commented 4 months ago

Right, I see. It is unfortunate that you've leaked your personal notes like that. But saving the workflow with PNG is the default behavior of Comfy, so I kept it here too and it is documented in the first paragraph in the readme:

For PNG stores both the full workflow in comfy format, plus a1111-style parameters. For JPEG/WEBP only the a1111-style parameters are stored.

That said, I can make it an option (default=ON) not to save the workflow for PNG.

lverangel commented 4 months ago

oh , that's my fault, i think it because i was used another plugin before, and there is a toggle "save workflow as json"....so i thought it will remove the workflow in PNG when i turn it on... but I would like submit PNG on civitai,and save low quality JPG as snapshot to save workflow.I'm not sure,maybe make an option is a good idea. great work,and sorry for my english.

Alexopus @.***> 于2024年5月11日周六 05:42写道：

Right, I see. It is unfortunate that you've leaked your personal notes like that. But saving the workflow with PNG is the default behavior of Comfy, so I kept it here too and it is documented in the first paragraph in the readme:

For PNG stores both the full workflow in comfy format, plus a1111-style parameters. For JPEG/WEBP only the a1111-style parameters are stored.

That said, I can make it an option (default=ON) not to save the workflow for PNG.

— Reply to this email directly, view it on GitHub https://github.com/alexopus/ComfyUI-Image-Saver/issues/18#issuecomment-2105304674, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3N3U7JSO3BMBPSW5W653ZBU5LJAVCNFSM6AAAAABGQO32M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGMYDINRXGQ . You are receiving this because you authored the thread.Message ID: @.***>