alexopus / ComfyUI-Image-Saver

Save images with Civitai-compatible generation metadata in ComfyUI
MIT License
49 stars 8 forks source link

get the file basename using os functionality #6

Closed nickve28 closed 10 months ago

nickve28 commented 10 months ago

This will strip the slashes accordingly, regardless of how the OS operates.

Should work for both the #model and #basemodelname attributes

closes #5

coderabbitai[bot] commented 10 months ago
Walkthrough ### Walkthrough The recent updates to the codebase primarily address an issue with checkpoint naming conventions. The changes involve renaming a function for better clarity, adding a new function to handle checkpoint names without file extensions, and refining the checkpoint naming process to exclude folder names from the base model name. These modifications ensure that metadata and file naming are consistent and error-free, particularly when models are stored within folders. ### Changes | File(s) | Change Summary | | --- | --- | | `nodes.py` | - Renamed `parse_name` to `parse_checkpoint_name`
- Added `parse_checkpoint_name_without_extension`
- Modified usage of renamed function with `os.path.basename` and `os.path.splitext`
- Removed `basemodelname` parameter usage
- Assigned `basemodelname` within `save_files` function | ### Assessment against linked issues | Objective | Addressed | Explanation | | --- | --- | --- | | #5: Correct `basemodelname` to exclude folder path from the name | ✅ | The changes to the parsing functions and the removal of `basemodelname` parameter where necessary, along with the correct assignment within `save_files`, should resolve the issue with folder names being included in the `basemodelname`. | | #5: Ensure metadata and file naming are accurate | ✅ | By refining the parsing of checkpoint names and ensuring the `basemodelname` is correctly determined, the metadata and file naming should now reflect the correct model names without folder paths. | | #5: Prevent `FileNotFoundError` caused by incorrect paths in file names | ✅ | The modifications made to the parsing of checkpoint names, which now likely include the use of `os.path.basename` and `os.path.splitext`, are expected to prevent incorrect paths from being included in file names, thus avoiding the `FileNotFoundError`. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.