Issue with color.ml - Githubissues

alexozer / flitter

A LiveSplit-inspired speedrunning split timer for Linux/macOS terminal. Supports global hotkeys.

MIT License

132 stars 11 forks source link

Issue with color.ml #16

Closed happycamper31 closed 3 years ago

happycamper31 commented 4 years ago

Hi, I managed to install opam & the dependencies but when I try 'dune build' I get following error:

File "src/colors.ml", line 5, characters 8-26:
Error: Unbound value Color.of_hexstring
Hint: Did you mean to_hexstring?

I played around with the code, but i have no clue about ocaml, so I stopped after some fruitless tries. I hope you can figure out by these lines what is going on. Regards

tonussi commented 4 years ago

I'm trying to understand why of_hexstring doesn't work properly. Maybe the output of of_hexstring is not being used correctly.

val of_hexstring : string -> t option
Parse a hexadecimal color code. Handles short format like #rgb or long format #rrggbb. Short format #abc corresponds to long format #aabbcc.

tonussi commented 4 years ago

The Color lib have a set of tests that could help us understand why the bug https://github.com/anuragsoni/color/blob/master/test/color_conversion.ml

alexozer commented 3 years ago

Seems to be fixed as of 666c5483bc93efa6d01e0b7a927461269f8e14de.