alexpado / hoyoverse-music-unpacker

Extract music from Hoyoverse's games. Support Genshin Impact, Honkai Star Rail and Honkai Impact
70 stars 7 forks source link

Wrappers not included in 1.4.0 release #20

Closed Cactism closed 4 months ago

Cactism commented 4 months ago

Not really sure why this is happening :(

Input & Output

PS C:\Users\Daniel\Downloads> java -jar "C:\Users\Daniel\Downloads\hoyoverse-music-unpacker-1.4.0.jar" --game="C:\miHoYo\Collapse\Appdata\SRGlb" --output="C:\Users\Daniel\Music\HSR" -t 4
Detecting game...
  -- Detected Honkai Star Rail (OS) !
Removing previous files...
Starting unpacking...
ovh.akio.hmu.exceptions.WrapperExecutableNotFound: Unable to access file .\wrappers\quickbms\quickbms.exe
        at ovh.akio.hmu.wrappers.Pck2Wem.<init>(Pck2Wem.java:22)
        at ovh.akio.hmu.GameUnpacker.unpackFiles(GameUnpacker.java:92)
        at ovh.akio.hmu.Application.regularExtract(Application.java:109)
        at ovh.akio.hmu.Application.call(Application.java:92)
        at ovh.akio.hmu.Application.call(Application.java:21)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2358)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2314)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2316)
        at picocli.CommandLine.execute(CommandLine.java:2078)
        at ovh.akio.hmu.Application.main(Application.java:70)

Machine Info

Cactism commented 4 months ago

I was able to work around this by downloading quickbms and vgmstream then recreating the "wrappers" folder structure. While the program successfully runs, it appears that no music files were unpacked.

https://github.com/alexpado/hoyoverse-music-unpacker/assets/88598340/f5b452a1-591d-4605-bad5-d4c2ee268145

Cactism commented 4 months ago

i cannot read ☠️ please ignore

alexpado commented 4 months ago

No no, wait, this is actually a valid point. I missed that for the 1.4.0 release, I only provided the JAR and not the ZIP file which includes the external tools

alexpado commented 4 months ago

I fixed the release :) Thank you for making me notice it !

Cactism commented 4 months ago

Ah, I assumed it was intentional where I had to download the source code .zip as well as the .jar then place .jar into the extracted source code folder, after reading the README.md. Thanks for taking the time to fix it either way!