search

alexpado / hoyoverse-music-unpacker

Extract music from Hoyoverse's games. Support Genshin Impact, Honkai Star Rail and Honkai Impact
70 stars 7 forks source link

Allow specifying an output directory #8

Closed aMytho closed 1 year ago

aMytho commented 1 year ago

This PR adds the ability to specify where your extracted files are placed with the output option.

Usage: java -jar "//path/to/jar" --game='//path/to/game' --output="F:\Users\User\Music"

I tested with and without the flag and it worked fine. I only used Genshin, but I'm assuming that since this is before the game-specific path it should work the same.

Closes #7

aMytho commented 1 year ago

Pushed the this fixes.

I think we can remove the "extracted" from the path if the user specifies an output. If they don't, we can keep the "extracted" as we still need a directory to point to. Otherwise it will probably extract to the same directory as the executable which isn't ideal.

alexpado commented 1 year ago

Fine by me. I'll do that at the same time that pre-download package are available for each game (around 4 weeks afaik). This will be the next update !

Thanks for the PR :)