search

alexpeachey / end_state

A State Machine implementation
MIT License
9 stars 5 forks source link

Transition shortcut breaking changes #14

Closed alexpeachey closed 10 years ago

alexpeachey commented 10 years ago

Addresses concerns raised in #13.

This is breaking change to the API!

@brianvh @charlierudolph please review when you get a chance.

brianvh commented 10 years ago

:thumbsup:

Of course, now I really want to move forward with a follow-on extraction of events into their own thing. Aside from capturing the starting and ending states, nearly all of the StateMachine class is dedicated to managing event info and the process of transitioning them. They're practically screaming at me to be extracted. :wink:

alexpeachey commented 10 years ago

I agree on the naming. I've changed it so both cases throw InvalidTransition.

alexpeachey commented 10 years ago

Oh but I didn't update the Readme...bugger. Updating in a moment. :smile: