search

alexpghayes / distributions3

Probability Distributions as S3 Objects
https://alexpghayes.github.io/distributions3/
Other
100 stars 16 forks source link

added introduction Poisson vignette based on the FIFA2018 example #74

Closed zeileis closed 2 years ago

zeileis commented 2 years ago

Alex @alexpghayes , as discussed in https://github.com/alexpghayes/distributions3/pull/73 I have now put together a vignette using the FIFA2018 example. I decided to provide some more context for the Poisson distribution, illustrating how you can go from a basic distributional fit to regression. I will give it another read but wanted to get it out there quickly so that you and @mnlang can also provide feedback and comments.

Note that the code reveals some problems with the plot() method for distribution objects but I'll propose a separate pull request for that.

Thanks in advance for your consideration!

alexpghayes commented 2 years ago

Thank you so much for this vignette!

zeileis commented 2 years ago

Thank _you_ for your feedback and for integrating it into the package! I've started working on some more count infrastructure (zero-adjusted Poisson distributions) and will try to make a PR about this soon.