alexprengere / currencyconverter

A Python currency converter using the European Central Bank data.
http://alexprengere.github.io/currencyconverter
Apache License 2.0
215 stars 59 forks source link

Incorrect coversion rate found #48

Closed Bugvi-Benjamin-M closed 1 year ago

Bugvi-Benjamin-M commented 1 year ago

Converting from DKK to USD with date 2023-08-09 gives an incorrect result.

As can be seen here:

Screenshot 2023-09-22 at 17 31 54

This is clearly not the correct conversion rate. The day before, i.e., 2023-08-08:

billede

I also checked with ECB and if I use their website to convert with the given date it also seems fine.

alexprengere commented 1 year ago

I think you have the wrong GitHub project. Here is how you would do this "here":

>>> from datetime import date
>>> from currency_converter import CurrencyConverter
>>> c = CurrencyConverter()

>>> c.convert(1, "DKK", "USD", date=date(2023, 8, 9))
0.1471997423199259
>>> c.convert(1, "DKK", "USD", date=date(2023, 8, 8))
0.14686975776689257

We also rely on ECB data, and it looks correct. You should either report this issue in their repo or use CurrencyConverter 😉

Bugvi-Benjamin-M commented 1 year ago

Oh boy. My apologies! How embarrassing.

But now at least I get to use a proper currency converter that actually works! Thanks heaps!