Closed alexpung closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces several updates to the Investment Tax Calculator
project. The project file now targets net8.0
, enables nullable reference types, and modifies the System.Text.Json
package version. Key components have been added or removed, including the inclusion of the ExportFile.razor
component. Additionally, a new method for filtering tax events has been added to the AssetTypeToLoadSetting
class, and various modifications have been made to the TaxEvent
and Trade
records, including validation logic and new methods.
File Path | Change Summary |
---|---|
InvestmentTaxCalculator.csproj |
Updated to target net8.0 , enable nullable reference types, publish trimmed, load globalization data, and updated System.Text.Json version from 8.0.4 to 8.0.5 . Removed DividendYearlySummary.razor , removed Pages\ExportFile.razor , included Components\ExportFile.razor . |
Model/AssetTypeToLoadSetting.cs |
Added method public TaxEventLists FilterTaxEvent(TaxEventLists taxEventLists) . |
Model/TaxEvents/TaxEvent.cs |
Added attribute [JsonPolymorphic()] , and added using directive for System.Text.Json.Serialization . |
Model/TaxEvents/Trade.cs |
Modified properties to include virtual and required modifiers, added validation logic, removed JSON serialization attributes, added methods AttachOptionTrade and PrintToTextFile . |
Parser/InteractiveBrokersXml/IBParseController.cs |
Removed conditional checks for loading asset types, added call to assetTypeToLoadSetting.FilterTaxEvent(result) . |
Parser/Json/JsonParseController.cs |
Updated constructor to accept AssetTypeToLoadSetting for filtering parsed tax event data. |
Components/AddTrade.razor |
Renamed and updated types for asset category variables, modified method OnInitialized , and updated grid column definitions. |
Components/MatchingDetailTable.razor |
Renamed property SelectedAssetCatagoryType to SelectedAssetCategoryType . |
Enumerations/AssetCatagoryType.cs |
Renamed enumeration from AssetCatagoryType to AssetCategoryType . |
Model/Interfaces/ITradeTaxCalculation.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/TaxEvents/FutureContractTrade.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/TaxEvents/FxTrade.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/TaxEvents/OptionTrade.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/TradeCalculationResult.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/UkTaxModel/Stocks/TradeTaxCalculation.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
Model/UkTaxModel/Stocks/UkTradeCalculator.cs |
Corrected enumeration type references to AssetCategoryType . |
Parser/InteractiveBrokersXml/IBXmlFutureTradeParser.cs |
Updated assignment from AssetCatagoryType.FUTURE to AssetCategoryType.FUTURE . |
Parser/InteractiveBrokersXml/IBXmlFxParser.cs |
Updated assignment from AssetCatagoryType.FX to AssetCategoryType.FX . |
ViewModel/TradeInputViewModel.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
ViewModel/TradeMatchViewModel.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
ViewModel/TradeTaxCalculationViewModel.cs |
Renamed property AssetCatagoryType to AssetCategoryType . |
AssetTypeToLoadSetting
class, which is relevant as it relates to filtering tax events, potentially impacting how options and trades are processed in the main PR.Trade
record, which is directly related to the changes in the main PR that involve updating properties and methods for handling trades, including options.refactoring
, bug
🐇 "In the garden of code, changes bloom bright,
With properties new, and methods in sight.
From trimming the project to filtering right,
The tax calculator hops into the light!" 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Updated the
System.Text.Json
package Move filtering logic of trade type from Parsers to AssetTypeToLoadSetting Fix serialisation problemSummary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes
These updates enhance the functionality and reliability of the Investment Tax Calculator, providing users with a more accurate and streamlined experience.