alexpung / UK-Investment-tax-calculator

Capital gain and dividend tax calculator for UK tax
https://alexpung.github.io/UK-Investment-tax-calculator/
Other
11 stars 2 forks source link

Fix and refactor JSON serialisation and parser #102

Closed alexpung closed 1 month ago

alexpung commented 1 month ago

Updated the System.Text.Json package Move filtering logic of trade type from Parsers to AssetTypeToLoadSetting Fix serialisation problem

Summary by CodeRabbit

Release Notes

These updates enhance the functionality and reliability of the Investment Tax Calculator, providing users with a more accurate and streamlined experience.

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several updates to the Investment Tax Calculator project. The project file now targets net8.0, enables nullable reference types, and modifies the System.Text.Json package version. Key components have been added or removed, including the inclusion of the ExportFile.razor component. Additionally, a new method for filtering tax events has been added to the AssetTypeToLoadSetting class, and various modifications have been made to the TaxEvent and Trade records, including validation logic and new methods.

Changes

File Path Change Summary
InvestmentTaxCalculator.csproj Updated to target net8.0, enable nullable reference types, publish trimmed, load globalization data, and updated System.Text.Json version from 8.0.4 to 8.0.5. Removed DividendYearlySummary.razor, removed Pages\ExportFile.razor, included Components\ExportFile.razor.
Model/AssetTypeToLoadSetting.cs Added method public TaxEventLists FilterTaxEvent(TaxEventLists taxEventLists).
Model/TaxEvents/TaxEvent.cs Added attribute [JsonPolymorphic()], and added using directive for System.Text.Json.Serialization.
Model/TaxEvents/Trade.cs Modified properties to include virtual and required modifiers, added validation logic, removed JSON serialization attributes, added methods AttachOptionTrade and PrintToTextFile.
Parser/InteractiveBrokersXml/IBParseController.cs Removed conditional checks for loading asset types, added call to assetTypeToLoadSetting.FilterTaxEvent(result).
Parser/Json/JsonParseController.cs Updated constructor to accept AssetTypeToLoadSetting for filtering parsed tax event data.
Components/AddTrade.razor Renamed and updated types for asset category variables, modified method OnInitialized, and updated grid column definitions.
Components/MatchingDetailTable.razor Renamed property SelectedAssetCatagoryType to SelectedAssetCategoryType.
Enumerations/AssetCatagoryType.cs Renamed enumeration from AssetCatagoryType to AssetCategoryType.
Model/Interfaces/ITradeTaxCalculation.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/TaxEvents/FutureContractTrade.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/TaxEvents/FxTrade.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/TaxEvents/OptionTrade.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/TradeCalculationResult.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/UkTaxModel/Stocks/TradeTaxCalculation.cs Renamed property AssetCatagoryType to AssetCategoryType.
Model/UkTaxModel/Stocks/UkTradeCalculator.cs Corrected enumeration type references to AssetCategoryType.
Parser/InteractiveBrokersXml/IBXmlFutureTradeParser.cs Updated assignment from AssetCatagoryType.FUTURE to AssetCategoryType.FUTURE.
Parser/InteractiveBrokersXml/IBXmlFxParser.cs Updated assignment from AssetCatagoryType.FX to AssetCategoryType.FX.
ViewModel/TradeInputViewModel.cs Renamed property AssetCatagoryType to AssetCategoryType.
ViewModel/TradeMatchViewModel.cs Renamed property AssetCatagoryType to AssetCategoryType.
ViewModel/TradeTaxCalculationViewModel.cs Renamed property AssetCatagoryType to AssetCategoryType.

Possibly related PRs

Suggested labels

refactoring, bug

🐇 "In the garden of code, changes bloom bright,
With properties new, and methods in sight.
From trimming the project to filtering right,
The tax calculator hops into the light!" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.