Closed alexpung closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The changes introduce a new method in the TaxYearCgtByTypeReportService
class to retrieve tax year reports for a specific year. Additionally, the UkCalculationResultExportService
class has been updated to accommodate new dependencies and methods for enhanced reporting capabilities. The constructor of UkCalculationResultExportService
now accepts two new parameters, and its methods have been refactored to improve the organization and output of financial summaries related to tax year calculations.
File Path | Change Summary |
---|---|
.../Services/TaxYearCgtByTypeReportService.cs |
Added method GetTaxYearCgtByTypeReport(int taxYear) and private method CreateReport(int taxYear) ; refactored GetTaxYearCgtByTypeReports() . |
.../Services/UkCalculationResultExportService.cs |
Updated constructor to include TaxYearCgtByTypeReportService and TaxYearReportService . Refactored WriteTaxYearSummary and added methods for overall and type-specific summaries. |
TaxYearCgtByTypeReportService
class, specifically the addition of the method GetTaxYearCgtByTypeReports(int taxYear)
, are directly related to the main PR's modifications in the same service class, which also introduced a new method for report generation.refactoring
🐰 In the garden of code, new blooms arise,
With reports for each tax year, a sweet surprise.
Services enhanced, with structure refined,
Summaries crafted, with metrics aligned.
Hopping through changes, we celebrate cheer,
For the tax year reports now shine bright and clear! 🌸
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Improve tax year summary and group disposals by asset type
Summary by CodeRabbit
New Features
Bug Fixes
Refactor