search

alexpung / UK-Investment-tax-calculator

Capital gain and dividend tax calculator for UK tax
https://alexpung.github.io/UK-Investment-tax-calculator/
Other
11 stars 2 forks source link

Option trade support fix #91

Closed alexpung closed 2 months ago

alexpung commented 2 months ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 months ago

[!WARNING]

Rate limit exceeded

@alexpung has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 58 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 683f0bed43a73200119df583f6f45b21221f9985 and 5ef0da358f094f612a4293f12d9b82641c52fbb2.

Walkthrough

The changes introduce modifications to the TaxEventLists, Trade, and OptionTradeTaxCalculation classes, refining how trades are added and validated. The TaxEventLists now filters trades to exclude options and futures, while the Trade class implements validation for Quantity and GrossProceed properties. Additionally, unit tests are updated and new tests are added for option exercises, ensuring comprehensive coverage of the new logic.

Changes

File Path Change Summary
BlazorApp-Investment Tax Calculator/Model/TaxEventLists.cs Updated AddData method to refine conditions for adding Trade instances, excluding OptionTrade and FutureContractTrade.
BlazorApp-Investment Tax Calculator/Model/TaxEvents/Trade.cs Modified Quantity and GrossProceed properties to include backing fields with validation logic, ensuring values are greater than 0.
BlazorApp-Investment Tax Calculator/Model/UkTaxModel/Options/OptionTradeTaxCalculation.cs Adjusted logic for handling exercised options, including new calculations for allowable costs and conditional checks based on option types.
BlazorApp-Investment Tax Calculator/Model/UkTaxModel/Options/UkOptionTradeCalculator.cs Changed message in MatchExercisedOption method to include premium cost details.
UnitTest/Test/Model/TaxEventListsTest.cs Updated AddData_AddsTaxEvents_CombinesAllLists test method to include assertions for FutureContractTrade and OptionTrade.
UnitTest/Test/TradeCalculations/Options/UkTradeCalculatorOptionExeciseTest.cs Introduced new unit tests for exercising options, validating calculations for long put and call options.
UnitTest/Test/TradeCalculations/Options/UkTradeCalculatorOptionExpireTest.cs Changed namespace and class name to better reflect focus on options, with updated method name for clarity.

Possibly related PRs

Suggested labels

refactoring

Poem

🐇 In fields of code, we hop and play,
With trades and taxes, we find our way.
New rules for options, clear and bright,
Validations ensure we do it right.
So let’s celebrate, with a joyful cheer,
For a cleaner codebase, we hold so dear! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.