search

alexrabarts / iso_country_codes

A Ruby library that provides ISO 3166-1 country codes/names and ISO 4217 currencies
http://github.com/alexrabarts/iso-country-codes
163 stars 62 forks source link

Allowed internationalization of country names #20

Closed moret closed 9 years ago

moret commented 9 years ago

Hi. I was looking for the list of countries in Portuguese in a convenient way as you did but couldn't find one, so I built a list myself and added via I18n to your project. Hope you like it. Bye!

dmke commented 9 years ago

:+1: I like it, though I would leverage the translation work to i18n_data.

moret commented 9 years ago

Hi @alexrabarts . Would you like me to make another pull request without the conflicts, fix this one or just drop it? 8)

greysteil commented 9 years ago

Hi @moret, sorry for leaving this PR hanging. I'm going to close because you'd be better off using this gem and https://github.com/onomojo/i18n-country-translations together - that's what we do at GoCardless.

moret commented 9 years ago

No problem. I'm going to check out i18n-country-translations, sounds like it's a perfect match for my needs too. 8)