search

alexrabarts / iso_country_codes

A Ruby library that provides ISO 3166-1 country codes/names and ISO 4217 currencies
http://github.com/alexrabarts/iso-country-codes
163 stars 62 forks source link

Ivory Coast -> english name, Cyprus in Europe #22

Closed ppotasiewicz closed 9 years ago

ppotasiewicz commented 9 years ago

Hi,

Maybe all countries name should be in english? I have changed Ivory Coast to english name. Cyprus is rather in Europe (I also find that it's in Asia but more sources say about Europe) so I correct this too.

moret commented 9 years ago

Though I agree with @ppotasiewicz that names should be in English, the ISO reference name for the code 'CI' is indeed 'Côte d'Ivoire'. https://www.iso.org/obp/ui/#iso:code:3166:CI . I think it should keep with the standard.

greysteil commented 9 years ago

@moret is right - we should stick with the auto-generated country names so that we're sticking to ISO-3166-1.

Continent code for Cyprus is up for grabs, however, as continents aren't included in the ISO-3166 standard. I'm :+1: on updating Cyprus to say it's in Europe.

@ppotasiewicz - if you want to override the Ivory Coast name in your application I recommend monkey patching (I wouldn't normally, but in this specific case you can be pretty certain the format of this gem won't change). At GoCardless we have the following to overrider the UK's name (which in the ISO standard is "United Kingdom of Great Britain and Northern Ireland"):

class IsoCountryCodes
  class Code
    class GBR < Code
      self.name = "United Kingdom"
    end
  end
end

If you update this PR to only affect the Cyprus continent then I'm :+1:.

greysteil commented 9 years ago

Closed in favour of https://github.com/alexrabarts/iso_country_codes/commit/7055e5c3ec53f8f4a7912477744d25b3441ce41e