search

alexrabarts / iso_country_codes

A Ruby library that provides ISO 3166-1 country codes/names and ISO 4217 currencies
http://github.com/alexrabarts/iso-country-codes
163 stars 62 forks source link

Wrong return of IsoCountryCodes.for_select in 0.7.2 #30

Closed AKovtunov closed 8 years ago

AKovtunov commented 9 years ago

Good day, I'm using your library and after release of 0.7.2 version IsoCountryCodes.for_select returns

 ["Virgin Islands (U.S.)", "VI"],
 ["Wallis and Futuna", "WF"],
 ["Western Sahara", "EH"],
 ["Yemen", "YE"],
 ["Zambia", "ZM"],
 ["Zimbabwe", "ZW"],
 [nil, nil]]

nil values at the end.

Reverted back to 0.7.1 and this problem has gone. Can someone else prove it? Is it a valid output?

greysteil commented 9 years ago

@AKovtunov you're totally right, and this is my bad - I made a typo in #29. Fixed in 77c993c9c5b054cd28fa7b2fe91a4c35a269e585, and I've also added a spec to ensure this can't recur.

@alexrabarts probably worth a patch release.

ur5us commented 8 years ago

@alexrabarts @greysteil Yes please, just ran into the same issue.

ur5us commented 8 years ago

@alexrabarts Ping

alexrabarts commented 8 years ago

Sorry for the delay in getting this released. I just pushed out 0.7.3.

greysteil commented 8 years ago

Thanks @alexrabarts. Can you add me on Rubygems?

alexrabarts commented 8 years ago

@greysteil Sure - I'll do that now.

greysteil commented 8 years ago

:heart:

alexrabarts commented 8 years ago

Done and Merry Christmas! We should meet up at #TechspaceConnect at some point @greysteil

AKovtunov commented 8 years ago

I'm still receiving your lovely comments, guys :smile:

greysteil commented 8 years ago

Ha, sorry @AKovtunov. @alexrabarts - indeed, let me know next time you're going!