Closed rob-anderson closed 11 years ago
Hi Rob,
The gem actually uses the ISO 3166-1 alpha-3 code, rather than the ISO 4217 currency code. The authoritative source for the gem is http://en.wikipedia.org/wiki/ISO_3166-1 - the codes:update
rake task is used to make the relevant updates in lib
. I'm not sure whether Zambia's ISO 4217 change has been reflected in ISO 3166. If you can confirm this and have the relevant edit accepted over at Wikipedia then I will issue a new release.
Cheers,
Alex
Hi Alex
Sorry, I think you have misunderstood the issue.
The ISO 3166 standard refers to country codes, not currency codes. The alpha-3 code for Zambia remains unchanged at ZMB.
However, the iso_country_codes gem also (helpfully) includes the ISO 4217 currency codes for each country. These are defined in file lib/iso_country_codes/iso_4217.rb
The entry for Zambia ZMB is listed as currency ZMK, when it should be ZMW - as per the ISO 4217 wikipedia page
It looks like the rake task pulls in any ISO 3166 changes, but not the ISO 4217 ones.
Rob
Sorry, Rob - it's been a while since I worked on this gem. Your patch is in version 0.3.1, which is now available on RubyGems.
Cheers,
Alex
Great - thanks!
Rob
Hi Alex
Effective 1st Jan 2013 the Zambian Kwacha was renamed from ZMK to ZMW (see http://en.wikipedia.org/wiki/Zambian_kwacha)
I'd be grateful if you could merge this commit and issue a point release
Thanks for maintaining this useful gem
Rob