search

alexrainman / CarouselView

CarouselView control for Xamarin Forms
MIT License
436 stars 176 forks source link

Fix for PositionSelectedCommand not working with custom Command #519

Open Dualitys opened 5 years ago

Dualitys commented 5 years ago

Files Changed:

  1. MainViewModel in Demo.csproj
  2. CarouselViewControl in CarouselView.FormsPlugin.Abstractions

Fixed the bindable property to correctly accept and return custom ICommand implementations, to work with Prism for example.

alexrainman commented 5 years ago

Awesome. Will merge this change.

alexrainman commented 4 years ago

I cannot use this in my current implementation as ICommand doesn't support type argument.

Dualitys commented 4 years ago

Could try fixing that if I knew where and how you need the typed argument