search

alexrainman / CarouselView

CarouselView control for Xamarin Forms
MIT License
436 stars 178 forks source link

Update CirclePageIndicator #525

Closed Phenek closed 5 years ago

Phenek commented 5 years ago

Hey Boy,

Here there is an update of CirclePageIndicator, for Xam >= 3.5

Hope you are ok!? Seeya

USAMA-app commented 5 years ago

is this updated in nuget package?

Phenek commented 5 years ago

Nop but you can compile your own nuget with it.

alexrainman commented 5 years ago

Version 1.0.3 should resolve this issue. CarouselView 6.0 will be out soon. I have been working hard on very cool functionality.

Phenek commented 5 years ago

Updating circlepageindicator in our project doesn’t work for many people. Like it’s explain in many duplicate issues.

This issue is here since 6months, many people ask for a workaround and here it is.

flaviosuardi commented 5 years ago

@alexrainman apply this PR in 5.2.0 version, please 🙏

LeoJHarris commented 5 years ago

@Phenek Your PR didnt work for me which XF version are you using in your project?

I got your PR and built the nuget package and added that as a reference, my own project i tried both XF 3.6.0.264807 and also latest 4.1.0.581479 and throwing the following exception:

System.NotSupportedException: Could not activate JNI Handle 0xbec37788 (key_handle 0x7d7fda0) of Java type 'md5cb1a4bab49bfe17ad6c0290694c1d310/CirclePageIndicator' as managed type 'Com.ViewPagerIndicator.CirclePageIndicator'.
LeoJHarris commented 5 years ago

Hi @alexrainman cool functionality is great! But we really need something that actually works atm which we have been missing for the last couple of months which is blocking issue. Can we a actually expect something? Thanks!

Phenek commented 5 years ago

Sorry @LeoJHarris for me it work. I’m using Xamarin 3.6, And I’m also on Mac. I can compile only for iOS and Android.

LeoJHarris commented 5 years ago

Hi @Phenek can i ask exactly which 3.6 version you are using? Thanks

Phenek commented 5 years ago

@LeoJHarris Sorry for the delay Here you can download the .nupkg I compiled it for iOS/Android only, It did not work for UWP.

Please Compile using Android Version (Target Framework) : >= Android 9.0 Pie it should work with Xamarin.forms >=3.6.0.344457

@alexrainman Hope you good the rest do not count

xleon commented 5 years ago

@Phenek

Please Compile using Android Version (Target Framework) : >= Android 9.0 Pie it should work with Xamarin.forms >=3.6.0.344457

This is a big blocker for our project and I tried your nuget (installing from a local folder repository) but I still get the same error 

System.NotSupportedException: Could not activate JNI Handle 0xff8f0328 (key_handle 0x26d99e3) of Java type 'md5cb1a4bab49bfe17ad6c0290694c1d310/CirclePageIndicator' as managed type 'Com.ViewPagerIndicator.CirclePageIndicator'. ---> Java.Lang.NumberFormatException: For input string: "15.0dip"

Probably because this PR is missing updates on nuspec: https://github.com/alexrainman/CarouselView/blob/master/nuget/CarouselView.nuspec#L174

alexrainman commented 5 years ago

An updated CirclePageIndicator package will be released with the next CarouselView. Not merging this PR. Thank you for your support.