alexrainman / CarouselView

CarouselView control for Xamarin Forms
MIT License
436 stars 178 forks source link

Fixing IllegalArgumentException while using many fingers to zooming #579

Open shnaz opened 4 years ago

shnaz commented 4 years ago

This is a fix to a android framework bug, which occurs when zooming on an image inside a ViewPager. Related to this bug: https://github.com/alexrainman/CarouselView/issues/563#issue-564995110

Known bugs: https://github.com/chrisbanes/photoview/issues/31 https://stackoverflow.com/questions/26315781/illegalargumentexception-pointerindex-out-of-range-when-i-pinchzoom-the-image

shnaz commented 4 years ago

We have had thousands of these exceptions in our apps. It would be so cool if this was fixed.

shnaz commented 4 years ago

@alexrainman Hi Alex, what do you think about this? best regards

alexrainman commented 3 years ago

@shnaz i am going to release a new version between today and tomorrow. Let's apply this fix to the new version instead.

shnaz commented 3 years ago

@alexrainman It would be great if this fix could come out soon, we still have a lot of these exceptions which we cant really do anything about ourselves.

shnaz commented 3 years ago

@alexrainman Hey man, sorry to bother you, but this keeps crashing our app and is actually the one with most occurences in our current app version. Any chance this gets released soon?

Thanks in advance

Best regards

dexxtr commented 3 years ago

I have absolutely the same bug as @shnaz has. Can we expect this fix in the next release, @alexrainman ? If yes, when it can happened? :)