iOS Timeout use wrong TimeSpan value

alexrainman / ModernHttpClient

ModernHttpClient

MIT License

126 stars 28 forks source link

Closed NazarHuliiev closed 5 years ago

NazarHuliiev commented 5 years ago

Hi @alexrainman . iOS handler use wrong value for timeout. Because of that there is no way to set more than 59 seconds. You should use TotalSeconds instead of Seconds in this line. https://github.com/alexrainman/ModernHttpClient/blob/f1de9a2f281b49a6c91e74ebc74914c1db657c1f/ModernHttpClient.iOS/NSUrlSessionHandler.cs#L217

Can you fix it and release new version? Thank you.

alexrainman commented 5 years ago

Yes I can do that.

NazarHuliiev commented 5 years ago

I created pull request for this. Thank you.

alexrainman commented 5 years ago

It is already fixed on my side.

NazarHuliiev commented 5 years ago

Thank you very much.