Prevent NullReferenceException in OnFailureCallback

[kvpt]

I encountered a crash recently using the library. From the stacktrace, it's caused by an NRE in the OnFailure method of the OkTaskCallback.

I added null check in two places :

• The hostname retrieval, perhaps not all check needed but I prefer to be safe
• The exception message, because it's a Java exception here, and in Java unlike C#, exception message can be null

The changes are only in the OnFailure method. I tried to disable the git normalization line ending but it doesn't seem to work 🤷‍♂.

[alexrainman]

Merging in next release.

[LucasRodriguez0302]

hey @alexrainman is there a plan on when this is going to be merged?

[alexrainman]

Couple of days. Working on a solution to support ECDSA.

[LucasRodriguez0302]

Is it possible to have a version with just this null check?

[kvpt]

I made a custom version with the patch included. To use it rename the zip to nupkg (github limit the extensions allowed). modernhttpclient-updated.3.5.1.zip

[LucasRodriguez0302]

hey @alexrainman me again, just checking if there's a plan for this update?

[simader]

Any news when the next release will be? Please merge this

[JasonBro]

Hi @alexrainman, I've just bumped into this problem as well and I can't see a nice easy way around it without this fix. Would it be possible to do a release of this, please?

Cheers

Jason

[alexrainman]

Releasing a new version this weekend.

[JasonBro]

Brilliant, @alexrainman - you're a star!

[simader]

Any news on that?

[LucasRodriguez0302]

hey @alexrainman is there a plan to release this soon?

[JasonBro]

Hi @alexrainman - I don't think this has been released yet; NuGet is still on release 3.4.3 released on 10 December 2019. Will there be a release soon?