search

alexrainman / ModernHttpClient

ModernHttpClient
MIT License
126 stars 27 forks source link

Will the NuGet be updated soon? #80

Open Shark107 opened 2 years ago

Shark107 commented 2 years ago

Hi,

first of all thanks for your work.

I noticed that this nuget hasn't been updated since December '19, while in the meantime the project has been going on - I manually created a nuget starting from the last version of the code and there is at least one bug fix solving a constant problem I had on a personal project.

Is there a plan to release a nuget on nuget.org with the latest update?

Thanks in advance

alexrainman commented 2 years ago

Yes

InquisitorJax commented 2 years ago

Hey @alexrainman - is there perhaps a general eta on a nuget update? We're running into this guy: https://github.com/alexrainman/ModernHttpClient/issues/75 - but it seems that's not part of the latest nuget release just yet?

InquisitorJax commented 2 years ago

@alexrainman do you have any updates on eta here?

I tried cloning the repo, but running into error: error: invalid path 'Thumbs.db:encryptable' ... looks like a windows-specfic issue for files containing ":" ?

gcadmes-extron commented 2 years ago

Hi @alexrainman , Whenever you do plan to update the ModernHttpClient, I thought I'd let you know that the last version of Square.OkHttp3 that is supported by ModernHttpClient is 4.9.2, approximately 7 months ago from the time I'm writing this message.

The most recent version of Square.OkHttp3 4.9.3 (as of today's date) throws a missing method exception:
System.MissingMethodException: 'Method not found: Square.OkHttp3.RequestBody Square.OkHttp3.RequestBody.Create(byte[],Square.OkHttp3.MediaType)'

I tried to fix it in the Android OkHttpNetworkHandler.SendAsync API using the recommended changes I found, however, it didn't throw where I had expected it to throw. Instead it threw on a call to System.Net.Http.HttpClient.GetStringAsync(requestUrl). This sounds a bit strange, I know. I am using VS Version 17.3.0 Preview 1.1 on a that is a .NET6 Maui Class library.

Do you think you can take a look at this missing method exception and upgrade to the latest Square.OkHttp3? Thanks for this fantastic library!!