search

alexrainman / nativescript-carousel-view

CarouselView plugin for NativeScript
MIT License
16 stars 5 forks source link

Indicators don't show on iOS until you swipe #15

Closed sitefinitysteve closed 7 years ago

sitefinitysteve commented 7 years ago

First off... AWESOME job on this plugin

On iOS though it seems there are no indicators when the app loads, but when you START to swipe they pop in.

Video: https://www.screencast.com/t/1kb3JwluwAup

sitefinitysteve commented 7 years ago

Sorry, had an idea of what the prob might be on the way in to work :)

The demo uses local data, my sample was using remote data .push (ed) onto the array in the NavigatingTo method... likely that's the problem?

alexrainman commented 7 years ago

In the case of remote data, please wait for the response and then assign items source. That will fix the problem. Also, i have a functionality named DragToLoad that will be the one to use in cases like yours.

alexrainman commented 7 years ago

I am releasing version 3 this week which supports empty array as source of the carousel. That will help.

sitefinitysteve commented 7 years ago

Thx mate, lets close this then :) 👍

sitefinitysteve commented 7 years ago

Could I just implant this in your head during testing :) I mean you might already know and v3 will fix, but...

There's issued with Livesync as well. So if I change my .js, no problems, everything reloads. If I change something in the css or xml though this line https://github.com/alexrainman/nativescript-carousel-view/blob/master/carousel-view.ios.ts#L321

Ends up having a source count of 0, even though I can see the model updating properly (though debug statements)