alexreisner / geocoder

Complete Ruby geocoding solution.
http://www.rubygeocoder.com
MIT License
6.35k stars 1.19k forks source link

AWS Location Service adapter does not store raw response in @data #1621

Open woodhull opened 1 year ago

woodhull commented 1 year ago

Expected behavior

While using AWS Location Service adapter, it should be possible to access the data property of responses using the data accessor.

Actual behavior

Geocoder::Result::AmazonLocationService stores the response in a @place variable while the base class expects the variable to be named @data

https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/amazon_location_service.rb vs https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/base.rb#L6

Steps to reproduce

Geocode results from AWS Location service are correct for the common attributes, but calling data always returns nil.

Environment info

alexreisner commented 1 year ago

Whoops! Thanks for this. The Result class should not define an initialize method. Open to a pull request. (cc @mplewis)