Open abdullahdevrel opened 1 year ago
Thank you for the detailed request! This sounds like a really nice service and I'd be happy to add support for it. Your approach (imitating GeoLite2) is exactly right. I'm sorry about the no-external-dependency rule. The best way to handle the maxminddb gem requirement is also to imitate the GeoLite2 lookup and print a console message if the lookup is selected and the gem isn't present. Feel free to get started on a PR, which I will be happy to review.
@alexreisner awesome! I really appreciate the approval! I had geocoder in my mind since we launched our free DB. We will get started with the PR. Thank you very much.
Context
I am the DevRel of IPinfo.io, and we really appreciate the support the library has for our API.
We are hoping to do a PR for integrating IPinfo's free IP databases for the project. We are hoping to write the integration code to support our free IP to Country ASN database.
Features of the database:
Database schema
Users can download the database using their free account access token. The download URL is:
The MMDB reader library facilitates only IP address lookups and no reverse IP lookups or information searches.
Review
We would appreciate a review from the maintainer(s) before we start coding. We are hoping to implement the feature set described here: https://github.com/alexreisner/geocoder/blob/master/README_API_GUIDE.md#geolite2-geoip2
The features I am seeing at this moment are:
If you have any feedback that will be greatly appreciated.