alexreisner / geocoder

Complete Ruby geocoding solution.
http://www.rubygeocoder.com
MIT License
6.35k stars 1.19k forks source link

Add lookup for Google Places Details API (New) #1637

Open patchy-oss opened 1 year ago

patchy-oss commented 1 year ago

Overview

Adds a lookup for Google Places Details (New).

Changes

Notes

Most of the changes are copy-paste with small corrections from the existing google lookups. I've tried to unify both google APIs, but seems like there's not too much to unify... Also I think the GoogleBase class is kinda redundant, so I can duplicate configure_ssl! and supported_protocols methods in both Google and GoogleNew instead (or maybe you have a better solution). Naming is tough 🙃

Google documentation:

maokomioko commented 7 months ago

@alexreisner Hi Alex, possible to merge you think?